Steve Haffenden
Steve Haffenden
Thanks for creating this pull request @manonromain, we're taking a look and will come back with questions if we have them.
@manonromain Just thinking about this, perhaps a different way of looking at this would be to implement a more generic filter where you can provide a value that you want...
How large is too large...
@monneyboi Hey Fella, did you ever come back to this?
Yes, that is my thinking. Redeploying is a bit of a pain for just updating a banner, and when you deploy, there is always the possibility that you screw up...
Doesn't seem like a bad idea. Can we spike this for a couple of days and see if we can shake out any significant disadvantages @tillprochaska?
@YurkoWasHere Thanks for taking the time to raise this issue and for being patient whilst we get back to you. It sounds like you've resolved this issue by updating Alephs...
Thanks for raising this issue @siccovansas. I would agree that this would be a nice to have feature for Aleph but the core team really do have capacity right now...
Hey @simonwoerpel Hope you're doing good. Have you had an opportunity to review the pull request and look into adding some tests around the changes you've made?
@simonwoerpel Did you ever manage to create or push any tests for this?