Rory O'Connell

Results 37 comments of Rory O'Connell

Sure. Would you consider separate PR updating the SDL build matching the glfw build or should I just leave it out?

Yep, currently `docking` head crashes with the glfw vulkan example and resize ![Peek 2020-08-15 14-36](https://user-images.githubusercontent.com/19547/90322089-d2ef9000-df04-11ea-867f-c3270f9584c9.gif) Looking at this now since my next work is getting #3372 working with docking.

>I have uploaded a simplified version of that fix here: >https://github.com/ocornut/imgui/compare/features/vulkan_resize_fix >For new code please try to stay within the code style. Sorry, I'm a bit lost on what you...

> For master, I believe my branch is a simpler replacement to your branch, and could be merged as-is later. I think yours is fine. Can you go ahead and...

Okay I updated, cherry-picked @ocornut `a65a6cae41d172c01d813da310e6b25d4fce5d80` and retargeted to `docking`. @hinxx Thank you for trying this out! As of this comment resizing the main window works, resizing any child windows...

Yeah, it works fully with viewports! I think this is good to go now. ![Peek 2020-08-18 17-46](https://user-images.githubusercontent.com/19547/90579407-c5434000-e17a-11ea-8c28-23b08f3874ed.gif)

Oh drat I forgot that it's possible that `vkAcquireNextImageKHR` could also return out of date. That's a rarer case though what @hinxx uses for a window manager trips it immediately....

That one has me concerned. Viewports are rendered in two functions RenderWindow and SwapBuffers. RenderWindow does a render pass and SwapBuffers does the page flip. I'm trying to think through...

Okay I went with nulling out the draw data approach. Hopefully that's the last of them.