Rory Barnes

Results 20 issues of Rory Barnes

The upgrade to v2.0 has created a few memory leaks. Tests are passing, but if you push the code into something that is not currently tested, please use caution.

v1.0.2 is currently not working with shared axis labels. See https://github.com/VirtualPlanetaryLaboratory/vplot/issues/8.

Right now the code opens and read the input files for every option. It'd be better to open them once and read the entire file into an array of chars,...

enhancement
good first issue

The option dinitIceSheetHeight in POISE allows negative arguments, which shouldn't be allowed. It'd be better to change it so that if the user inputs a negative value, it defaults to...

bug
good first issue

When the code outputs parameters, it loops over all possible values, MODULEOPTEND, which is inefficient. Instead the code should record the number of outputs per body and just loop over...

enhancement
good first issue

A halt needs to be added to ensure POISE is not used at high eccentricity.

bug
good first issue

In 1 star, 2 planet systems where EQTIDE and DISTORB are active, and if tides are significant on the outer planet, the evolution can fail to conserve energy. The evolution...

bug

Gijs Mulders suggested that it would be useful to include commented-out headers in output files. These will be ignored by most python I/O functions, like numpy's genfromtxt of pandas' read_tables,...

enhancement
good first issue

Central bodies do not have orbital parameters (they can be orbited by many bodies), so orbital parameters are reported as -1. There might be a better way to do this...

enhancement

Spinbody and distorb both have functions to convert between orbital elements and Cartesian coordinates. These should be combined into 1 and moved into system.c.

enhancement