Rommel Layco

Results 6 comments of Rommel Layco

The test that is currently failing are `test/test_storage.py::test_storage_local_with_prefix` `test/test_storage.py::test_storage_local_no_prefix` It looks like this rohum commit broke the test https://github.com/aiven/rohmu/commit/b4861247ea3e5ca364566416d3415f1a535f97dd as it fails to save the metadata now.

> The test that is currently failing are > > `test/test_storage.py::test_storage_local_with_prefix` `test/test_storage.py::test_storage_local_no_prefix` > > It looks like this rohum commit broke the test [aiven/rohmu@b486124](https://github.com/aiven/rohmu/commit/b4861247ea3e5ca364566416d3415f1a535f97dd) as it fails to save the...

Looks like the test were failing due to rohum. This has been fixed here https://github.com/aiven/rohmu/pull/76

The issue is that the datadog sdk ignores any parameters that are not defined for the method. In this case the we are making the following api call https://github.com/ansible-collections/community.general/blob/main/plugins/modules/monitoring/datadog/datadog_monitor.py#L384 ```python...

@zhan9san are you still working on this? @kdaily, @tim-finnigan or @dlm6693 what needs to be done to get this reviewed

Is there anything i can do to help speed up the review? Note that we could always add `pysocks` as an extra dependencies to the pyproject.toml. that way they are...