Rodrigo Quelhas

Results 95 comments of Rodrigo Quelhas

> @RomarQ I think it's important that the new opcodes should only be enabled when the Cancun fork is used and not for previous forks. We should add a flag...

> @RomarQ Please resolve the conflicts Done

@sorpaas can you have a look at these changes? I splitted these changes from the #278 to make the review easier.

> @RomarQ could you split this PR into three PRs? > > * PR1: fix eip1559 > * PR2: fix eip2929 (and update jsontests in CI) > * PR3: add...

> Could you add [`ethtests/GeneralStateTests/Cancun/stEIP1153-transientStorage`](https://github.com/ethereum/tests/tree/develop/src/GeneralStateTestsFiller/Cancun/stEIP1153-transientStorage) into jsontests in CI This depends on https://github.com/rust-ethereum/evm/pull/288. We can test it this way: ```sh cargo run --release --verbose -p jsontests -- jsontests/res/ethtests/GeneralStateTests/Cancun/stEIP1153-transientStorage --debug ```

Once we enable tests for `Cancun` fork here: https://github.com/rust-ethereum/evm/blob/8168ca150abce577a4fb78d2da0918d229939b9e/jsontests/src/run.rs#L106 if we run all the tests, some will fail, mainly because there are still a few incompatibilities after berlin (gas related)....

https://github.com/rust-ethereum/evm/pull/278 adds support for EIP-1153

https://github.com/rust-ethereum/evm/pull/279 adds support for EIP-5656

I suspect it is a bug introduced by https://github.com/airgap-it/tezos-rust-sdk/pull/19. Will try to have a look at it when possible. Thanks for the report :+1:

Thanks for the reproducible example. It should be fixed on develop. I will add a test for it this specific case on the weekend.