Denys Romanenko

Results 16 comments of Denys Romanenko

Hi, thank you for reply. > Hi thank you for the PR. I haven't looked at the contents yet, a couple thoughts: > > * because accidentally removing owner references...

~~One problem is unsolved - when local matrix tests fail, make stops executing task, and symlinks cannot restore.~~

@munnerz Hello > A few questions from an end-user perspective: > > 1. if I set `cleanupPolicy: Delete` and then issue a certificate, and then realise afterwards I _don't_ want...

@munnerz > Please also update the release note in-line with the new API surface/design :) updated, thanks !

@munnerz > I don't think we should only have these apply on secret creation - this is confusing for the user and could lead to unexpected data loss (or leaving...

> Regardless of any other outcomes, I am _strongly_ -1 on having `cleanupPolicy` only apply on issuance - this will lead to confused users and data loss, and will also...

> Hey, I'll enable the tests (I had forgotten to enable them) > > /ok-to-test > > Apologies for the delay on the review. I'll ask the current release managers...

> Hi, I'll be away until 2 Jan 2022. I'll continue reviewing then. You can ask @SgtCoDFish or @wallrj if you need assistance in the meantime. Hi, it's not a...

> Hey. It looks very promising! I see that you have added tests everywhere needed. We are very close to being able to merge this! I'll wait for the CI....