Roman Brodetski

Results 17 comments of Roman Brodetski

Here are two exports of the same metric, taken with a little delay in between (changed the extension to txt as otherwise github wouldn't accept it): [export2.txt](https://github.com/VictoriaMetrics/VictoriaMetrics/files/9574221/export2.txt) [export1.txt](https://github.com/VictoriaMetrics/VictoriaMetrics/files/9574222/export1.txt) Current setup:...

These two exports are from the same metrics, but queried with a small delay in between. You can see that the data is different. There is a sequence `149000,150631,152463` in...

The first mismatch is on timestamp 1663230651530

@mm-zk I'd say this is not a `chore` but a `feat`. Would want to see this in changelog

@EmilLuta we also have some tables related to proofs that are not used, **and are there from ZkSync Lite**. I think it's `aggregated_proof` and `proof`. Let's also delete them here...

> in last 5 days there were 5 releases, can't they been joint together in one release ? @hdiass in theoery they could, but we have our internal deployment system...

I think @githubdoramon raised it on our call

https://github.com/matter-labs/zksync-era/pull/1056#issuecomment-1953124211 Is it true? @koloz193 cc @joonazan

Hmm for some reason in the description the code has some encoding issues: ``` commit_criteria: Vec<Box<dyn L1BatchPublishCriterion>>, proof_criteria: Vec<Box<dyn L1BatchPublishCriterion>>, ``` Can you please paste again?

this is definitely not a `chore`. Remember that `chore` doesn't end up in changelog. This is a `feat`.