Roman Netrogolov

Library decomposition

1

Despite of well structure inside the only one .py file, it is actually not a good practice. I faced an issue on my own and made a comparison of my...


Preliminary changes for release (WIP)

1

# Checkers policy As mentioned in the #33, more structured way for checks should be made, namely, string-base constants should be replaced with enumerators and special objects for checking should...

Problem If names of nodes are too broad, borders of table's cells are shifted.

Для большей читаемости лучше gru.nodes_types(discretized_data).values() вынести в переменную. И переработать в all([node_type in discrete_types for node_type in nodes_types]) Можно в целом вынести такую проверку в функцию вроде is_discrete - явно...

Not all possible convinient models (sklearn) are covered in tests.

Some metrics are another files (e.g. `mi_entropy_gauss`, `redef_HC`), this is not compatible with entire BAMT logic. Therefore, these files must be decomposed and integrated as Builders in BAMT Logic. -...

Fit paramenets method is too big, it should be decomposed.

The output from following function from ```urllib``` in search function returns nonsence if terms have cycillic symbols. ``` escaped_term = urllib.parse.quote_plus(term,) ``` Passing encoding (utf8) doesn't solve problem. For my...

Recently during work on another project I found that w/o implicit init of my logger it usually has strange handler in parent logger (root logger). ``` logger = get_logger("estimators", level=logging.DEBUG)...