Rohan Raj
Rohan Raj
@david-allison Sorry It took little late to go through the code and actually find a good approach as per my understanding of codebase yet. But I feel things are working...
@david-allison Can you please review the code ?
 Current dialog box!!
@Arthur-Milchior Ping
> The first commit doesn't compile > > ``` > > Task :AnkiDroid:compileAmazonDebugKotlin FAILED > e: file:///C:/Work/Anki-Android/AnkiDroid/src/main/java/com/ichi2/anki/AndroidTtsPlayer.kt:111:80 Argument type mismatch: actual type is 'com.ichi2.anki.AndroidTtsError.SpeechRateFailed', but 'com.ichi2.libanki.TtsPlayer.TtsCompletionStatus' was expected. > e:...
@david-allison My understanding behind the change is that InvalidVoiceError addresses the particular issue mentioned above.
I am working on this issue!!
Hey @romani I tried using AST based methods for WriteTagCheck.java. But I found that In checkstyle's AST comments are not direct siblings of class/method nodes.
Not necessary, I think just overriding the `isCommentNodeRequired()` func of AbstractCheck and making it return true will work in enabling the comments as a AST sibling. ``` @Override public boolean...