Anki-Android
Anki-Android copied to clipboard
ankidroid
CI should test 16kb and non-16kb page alignment in libraries, packaging, and emulator
with upcoming need to be "16kb alignment clean" the CI matrix for emulator tests should be updated to run against a 16kb emulator as well as a regular emulator. Suggest using this API/image-name tuple:
android-35;google_apis_ps16k
The page size should be verified in CI prior to execution, via the tests on linked google doc
Additionally, the .apk should be extracted and have .so file verification of page-alignment checked, and finally the zipalign should be checked - otherwise we won't know if we have actually done the work or not, and we won't track any random regressions
Originally posted by @mikehardy in https://github.com/ankidroid/Anki-Android-Backend/pull/402#discussion_r1723732098
Hello 👋, this issue has been opened for more than 3 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Should be automated, but it's worth mentioning that I run it on both types of emulators from time to time and the app runs. So we are clean currently, we just don't test it in CI
Hello 👋, this issue has been opened for more than 3 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically
@Haz3-jolt When you have a second, could you summarize how this is blocked, either here or on the linked PR
We need to test on 16kb page size emulators, but the runners we use android-emulator-runner, which doesn't yet have a release with the PR adding in support for 16kb emulators.
@david-allison @Haz3-jolt the suggested workaround was to depend directly on the commit in the upstream action from where they merged the PR I posted to them that implemented the support we need
I did that and the PR is running CI now, hopefully it finishes up... https://github.com/ankidroid/Anki-Android/pull/18248
no need to wait on upstream release when we've got a commit hash for them
Well, that's disappointing. @actions/core not found !? so CI still failed when it tried to run that action based on the commit hash, which is unexpected. So this is still blocked until they release upstream or we figure out how to make that action run from a commit hash
Well, that's disappointing.
@actions/core not found!? so CI still failed when it tried to run that action based on the commit hash, which is unexpected. So this is still blocked until they release upstream or we figure out how to make that action run from a commit hash
I'm pretty sure this is because github actions really does not like it when we run an action on a commit hash. I've faced similar issues with a friend's project.