RogerSans

Results 22 comments of RogerSans

Migration to version 17.0

Working on membership_variable_period https://github.com/OCA/vertical-association/pull/171

Migration to version 17.0

Working on sale_comment_template https://github.com/OCA/sale-reporting/pull/279

[17.0][MIG] membership_extension: Migration to 17.0

Solved THNX

[17.0][MIG] membership_extension: Migration to 17.0

> Code and functional review. > > The migration seems good > > However, can you remove the membership_variable_period module from this migration. > > Migrations PR's should only migrate...

[17.0][MIG] membership_extension: Migration to 17.0

@HaraldPanten Yes, I have made the changes that Alberto requested. However, in the pre-commit fix there is a reference to this module since a problem with a false error given...

[17.0][MIG] membership_extension: Migration to 17.0

@HaraldPanten @ValentinVinagre done

[17.0][ADD]sale_invoice_disable_salesperson_autosubscribe: disables salesperson autosubscription when creating invoices.

@ValentinVinagre Can you review PLS? THX

[17.0][ADD]sale_invoice_disable_salesperson_autosubscribe: disables salesperson autosubscription when creating invoices.

@manuelregidor Can you review this pls? THX

[17.0][ADD]sale_invoice_disable_salesperson_autosubscribe: disables salesperson autosubscription when creating invoices.

Thanks for the review Pedro. I'm actually changing it.

[17.0] [MIG] sale_order_invoicing_grouping_criteria: Migration to 17.0

> @RogerSans you forgot to add Sygel contributors. Didn't you? Yes, my mistake. Added.