vertical-association [17.0][MIG] membership_extension: Migration to 17.0

Standard migration T-6475

@HaraldPanten @ValentinVinagre

Aug 01 '24 15:08 RogerSans

Solved THNX

Aug 02 '24 11:08 RogerSans

Code and functional review.

The migration seems good

However, can you remove the membership_variable_period module from this migration.

Migrations PR's should only migrate one module

@RogerSans

Changed. THNX

Aug 19 '24 06:08 RogerSans

@RogerSans don't you still have changes in membership_variable_period module ? Check pre-commit commit as well and make sure you are not including anything from membership_variable_period_module.

THX

Aug 20 '24 11:08 HaraldPanten

@HaraldPanten Yes, I have made the changes that Alberto requested. However, in the pre-commit fix there is a reference to this module since a problem with a false error given by flake8 in the lambda function had to be solved. If I have to do it in a different pr I will change it.

Aug 20 '24 12:08 RogerSans

/ocabot migration membership_extension

Aug 20 '24 17:08 rafaelbn

@RogerSans please remove the "membership_variable_period" module.

Aug 20 '24 18:08 ValentinVinagre

MT-7084 @moduon please @edlopen @fcvalgar review 😄 ❤️

Aug 20 '24 18:08 rafaelbn

@HaraldPanten @ValentinVinagre done

Aug 21 '24 06:08 RogerSans

THX for the reviews, @fcvalgar and @edlopen 👍

I think that now that we have functional and technical reviews, this PR is ready to merge. Could you do that, @rafaelbn ?

Aug 21 '24 07:08 HaraldPanten

@ValentinVinagre do you agree to merge?

Aug 21 '24 07:08 rafaelbn

/ocabot merge patch

Aug 21 '24 07:08 rafaelbn

This PR looks fantastic, let's merge it! Prepared branch 17.0-ocabot-merge-pr-170-by-rafaelbn-bump-patch, awaiting test results.

Aug 21 '24 07:08 OCA-git-bot

Congratulations, your PR was merged at caf7591150d13fedbb5d45e11041d8e4332a5812. Thanks a lot for contributing to OCA. ❤️

Aug 21 '24 07:08 OCA-git-bot