RogerGinBer

Results 8 comments of RogerGinBer

That looks very cool, @jorainer ! :+1: I'll give it a try and let you know if I need anything else

Hi Emily, I've tracked the error down and it's due to a problem with the GUI itself, not with the `filterSOI` function. Thankfully, it was just a silly variable name...

Hi Emily, Have you reinstalled/updated the package lately with `devtools::install_github("RogerGinBer/RHermes")` to apply the latest commit changes? I've run some tests in the GUI and `filterSOI()` works with both the test...

Hi Johannes, thanks for the code review! About the algorithms: - Regarding peak-picking: as I commented above, this sequential 1D + 1D peak-picking (ie. first in the RT domain, and...

Good! I think I'll keep the IM ranges in the `chromPeaks` matrix for now, since its something "essential" that defines the peaks I'll keep you updated by posting new commits...

Yep, you're right, I completely forgot about that! :pray: Until now I've been running some tests locally, since I didn't know that you could change the backend from the read-only...

Hi there! I've added a very compact IM dataset that contains a mz-rt region where an intense peak and its M1 isotope can be found. I've added unit tests for...

Thanks for the heads-up @sneumann! I've updated the branch to devel (https://github.blog/2016-08-15-change-the-base-branch-of-a-pull-request/)