fuselage icon indicating copy to clipboard operation
fuselage copied to clipboard

refactor: remove unimplemented components from index

Open tapiarafael opened this issue 2 years ago • 5 comments

Proposed changes (including videos or screenshots)

Remove unimplemented components from the index file, so they don't appear on the intellisense.

Issue(s)

Further comments

This change is made to avoid confusion during the development using ui-kit, since the components would not work as they aren't implemented yet.

Task AE-56

tapiarafael avatar Sep 30 '22 13:09 tapiarafael

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 30 '22 13:09 CLAassistant

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Sep 30 '22 13:09 CLAassistant

why not implement the components? since now we moved the fuselage-ui-kit to the main repo, thing are much easier to be done..

ggazzo avatar Oct 06 '22 02:10 ggazzo

I believe it's fine. The exposed API should really reflect what we have at the moment. Future components are better described in spec files.

tassoevan avatar Oct 27 '22 19:10 tassoevan

why not implement the components? since now we moved the fuselage-ui-kit to the main repo, thing are much easier to be done..

I agree with you, but it's not the focus of the task at the moment. We are trying just to improve the experience of people that will use the fuselage, to not misunderstand what the available components are.

tapiarafael avatar Nov 18 '22 12:11 tapiarafael

Closing since ui-kit was moved to rocket.chat monorepo

dougfabris avatar Jul 17 '24 15:07 dougfabris