Juan Rocamonde

Results 18 issues of Juan Rocamonde

Currently, `fetchAccessToken` must return a `Promise` object. This works fine if the token is fetched using `fetch` via REST. However, my API also uses GraphQL for refreshing tokens (as I...

Fixes #461. - [x] Support seeding via generator - [x] Implement base class update params - [ ] Add regularization param change to logger - [x] Add loss_regularize - [x]...

- [ ] Add FAQs to the FAQ page - [ ] Fill in the `what is imitation page' - [ ] Add greater detail to README.md table with implementations

enhancement
docs

## Description Fixes the return type of `.load()` and `.learn()` methods in `BaseAlgorithm` so that they now use the `Self` type [PEP 0673](https://peps.python.org/pep-0673/) instead of `BaseAlgorithm`, which breaks type checkers...

### 🚀 Feature `preprocess_obs` returns a tensor or a `Dict[str, th.Tensor]` depending on whether the observation space is a dict space or not. The return type hint does not indicate...

enhancement

### 🚀 Feature This issue is to discuss the possibility of including tests in the type checking CI pipeline. ### Motivation Currently, tests are not being type checked, which means...

enhancement

### 🐛 Bug The return type of methods `.load()` and `.learn()` in `BaseAlgorithm` is annotated as `"BaseAlgorithm"`, which means that for any subclass that does not override the methods with...

enhancement

## Description Fixes #501. (Depends on https://github.com/HumanCompatibleAI/seals/pull/58).

Type definitions like https://github.com/HumanCompatibleAI/imitation/blob/4232b454b61181e322a666b7ef4c684afa587516/src/imitation/policies/serialize.py#L23-L23 can (and should be, for better type safety) replaced with the usage of Protocol + ParamSpec. Example: ```python from typing import ParamSpec, Protocol P = ParamSpec("P")...

enhancement

Moving the discussion on https://github.com/HumanCompatibleAI/imitation/pull/534#discussion_r963202712 to its own issue: ## Problem We currently use `./ci/code_checks.sh` as a script to do a variety of code checks that are required for CI...

enhancement