ServoESP32 icon indicating copy to clipboard operation
ServoESP32 copied to clipboard

Order of parameters in attach

Open s00500 opened this issue 6 years ago • 3 comments

This library changes the order of parameters in the attach() function as compared to the standard arduino library, please change this or document it! Thanks

s00500 avatar Apr 16 '18 17:04 s00500

Yes, that is my fault. I'm probably creating a new interface for the function attach() with two options:

  1. compatible with Arduino servo library - without parameter channel -> channel will be set automatically
  2. parameter channel change from int to enum class and then the standard function overloading will work

What do you think about this change?

JarekParal avatar Apr 16 '18 18:04 JarekParal

yes perfect, I was also thinking about having the channel as an optional attribute :-)

s00500 avatar Apr 17 '18 17:04 s00500

Actually, I improve the documentation and in the future, I would like to refactor the library with cooperation to #2.

JarekParal avatar Mar 01 '19 11:03 JarekParal