rosbridge_suite Fix length-limited list types

Public API Changes

None

Description

Removes the , N length specifier at the end of list types like sequence<type, length>. Fixes issues with serializing shape_msgs/Polygon, which has a float64[<=3] field.

Fixes #910

Feb 24 '23 23:02 EzraBrooks

@achim-k can I get a review? this is a pretty brutal issue - it prevents serializing Polygons, which many planning- and geometry-related messages include.

Mar 01 '23 16:03 EzraBrooks

@EzraBrooks #827 looks like it does the same / something similar. Can you check that one?

Mar 01 '23 19:03 achim-k

This PR has been marked as stale because there has been no activity in the past 6 months. Please add a comment to keep it open.

Sep 03 '23 00:09 github-actions[bot]

Got to the same solution. This solution seems ready to merge.

Oct 02 '23 09:10 JensVanhooydonck

@achim-k The other PR (#827) has been closed and this one is tested and ready to merge. Can we merge this one in?

Oct 12 '23 13:10 sea-bass

Closing in favor of #883, which fixes this particular issue and others.

Oct 26 '23 18:10 EzraBrooks

Turns out this is still needed!

Jun 07 '24 18:06 EzraBrooks

or at the least, my team is still running into an issue when serializing moveit planning scenes as described in #910. will dig a bit deeper, but this PR definitely fixes it

Jun 07 '24 18:06 EzraBrooks

@EzraBrooks I was just looking through PRs to this repo and noticed this was still hanging around. Is this good to merge now? Will let you go ahead if so.

Aug 15 '24 03:08 sea-bass