drake icon indicating copy to clipboard operation
drake copied to clipboard

Upstream VTK patches

Open svenevs opened this issue 1 year ago • 6 comments
trafficstars

Several Drake patches to VTK should be up-streamed:

The latest version of the patches can be found here.


Once all are upstreamed, we should bump Drake to VTK master and adjust the (now shorter) list of patches:

  • [ ] Upgrade Drake's VTK pin

These patches were an outcropping of #20867, and other related work.

CC @jwnimmer-tri @BetsyMcPhail

svenevs avatar Feb 02 '24 21:02 svenevs

Okay, I've finished the patch inventory @BetsyMcPhail . We have 4 items to upstream.

jwnimmer-tri avatar May 09 '24 19:05 jwnimmer-tri

@kwryankrattiger is going to work on this issue.

BetsyMcPhail avatar May 16 '24 16:05 BetsyMcPhail

Patches MR'd to VTK upstream

kwryankrattiger avatar May 16 '24 19:05 kwryankrattiger

  • [x] Adding https://gitlab.kitware.com/vtk/vtk/-/merge_requests/11117 here as well so it doesn't get forgotten about. It was patched to drake in #21387

BetsyMcPhail avatar May 16 '24 19:05 BetsyMcPhail

I pulled out the configurable exponent part of the illumination patch into a separate MR here: VTK/VTK!11374

kwryankrattiger avatar Aug 07 '24 15:08 kwryankrattiger

FYI #22052 should help make the tracking of upstreamable patches easier.

jwnimmer-tri avatar Oct 16 '24 21:10 jwnimmer-tri

BetsyMcPhail avatar Jan 13 '25 16:01 BetsyMcPhail

Upstreamed patches are removed in #22597

BetsyMcPhail avatar Feb 06 '25 20:02 BetsyMcPhail

All patches have been upstreamed, the remaining test issues can be tracked in the PR listed above.

BetsyMcPhail avatar Feb 11 '25 21:02 BetsyMcPhail