drake
drake copied to clipboard
Upstream VTK patches
Several Drake patches to VTK should be up-streamed:
- [x] camera_copy.patch VTK/VTK!11125
- [ ] fix_illumination_bugs.patch VTK/VTK!11146
- [x] subset of illumination - VTK/VTK!11374
- [x] gltf_parser.patch VTK/VTK!11126
- [x] gltf_quiet_image_errors.patch VTK/VTK!11130
- [x] mr11117.patch VTK/VTK!11117
The latest version of the patches can be found here.
Once all are upstreamed, we should bump Drake to VTK master and adjust the (now shorter) list of patches:
- [ ] Upgrade Drake's VTK pin
These patches were an outcropping of #20867, and other related work.
CC @jwnimmer-tri @BetsyMcPhail
Okay, I've finished the patch inventory @BetsyMcPhail . We have 4 items to upstream.
@kwryankrattiger is going to work on this issue.
Patches MR'd to VTK upstream
- [x] vtkCamera Copy VTK/VTK!11125
- [ ] Illumination VTK/VTK!11146
- [x] GLTF Parser VTK/VTK!11126
- [x] GLTF Error Handling VTK/VTK!11130
- [x] Adding https://gitlab.kitware.com/vtk/vtk/-/merge_requests/11117 here as well so it doesn't get forgotten about. It was patched to drake in #21387
I pulled out the configurable exponent part of the illumination patch into a separate MR here: VTK/VTK!11374
FYI #22052 should help make the tracking of upstreamable patches easier.
- [x] fix_illumination_bugs.patch. VTK MR: https://gitlab.kitware.com/vtk/vtk/-/merge_requests/11881
- [x] gltf_importer_from_stream.patch VTK MR: https://gitlab.kitware.com/vtk/vtk/-/merge_requests/11861
- [x] gltf_selected_load.patch VTK MR: https://gitlab.kitware.com/vtk/vtk/-/merge_requests/11837
- [x] io_geometry_gltf_default_scene.patch VTK MR: https://gitlab.kitware.com/vtk/vtk/-/merge_requests/11836
Upstreamed patches are removed in #22597
All patches have been upstreamed, the remaining test issues can be tracked in the PR listed above.