drake icon indicating copy to clipboard operation
drake copied to clipboard

VTK Dependency Audit

Open svenevs opened this issue 3 years ago • 1 comments

External dependencies for the VTK builds need to be inspected. From https://github.com/RobotLocomotion/drake/issues/16502#issuecomment-1254102689

Confirmation that these are included in the drake setup scripts for macOS is the primary concern since we intend to distribute an archive rather than rely on brew formula dependencies. Beyond that, these may be good to prune out or make explicit dependencies of drake's setup/ scripts.

Ubuntu

https://github.com/RobotLocomotion/drake/blob/6f88ff94665cbf88ca87d17a4e6fe5ca443030a7/tools/workspace/vtk/image/vtk-args#L252-L274

  • [ ] exprtk
  • [ ] fmt
  • [ ] libharu
  • [ ] pugixml
  • [ ] utf8

macOS

https://github.com/RobotLocomotion/homebrew-director/blob/ed5a2b2e28eec69ee9c0aab26322c4d61a89cac2/Formula/vtk%409.1.0.rb#L345-L367

  • [ ] exprtk
  • [ ] fmt
  • [ ] libharu

svenevs avatar Sep 21 '22 21:09 svenevs

Per platform checklist, assigning @jwnimmer-tri as lead for delegation etc.

EricCousineau-TRI avatar Sep 22 '22 14:09 EricCousineau-TRI

Updates from f2f today:

Most likely the only remaining work is to deal with these three libraries:

  • libpng
  • libtiff
  • libjpeg

See TODOs in @vtk_internal:

https://github.com/RobotLocomotion/drake/blob/d718147dd37c110004848cb37f46cae8ab58eb99/tools/workspace/vtk_internal/settings.bzl#L526-L532

https://github.com/RobotLocomotion/drake/blob/d718147dd37c110004848cb37f46cae8ab58eb99/tools/workspace/vtk_internal/settings.bzl#L550-L555

https://github.com/RobotLocomotion/drake/blob/d718147dd37c110004848cb37f46cae8ab58eb99/tools/workspace/vtk_internal/settings.bzl#L561-L566

The goal is to make sure all three of those are properly vendored, ideally with drake_vendor_foo prefix not just vtkfoo.

Remember that libtiff got angry last time we tried this. Figure out why.

jwnimmer-tri avatar Sep 14 '23 20:09 jwnimmer-tri

@libpng was fixed in #20276 @libtiff was fixed in #20331. @libjpeg was fixed in #20343.

jwnimmer-tri avatar Mar 16 '24 01:03 jwnimmer-tri