Robin van der Vliet
Robin van der Vliet
Why disable taking screenshots? This will only limit it on some devices and you can easily bypass this 'fix'.
> Not sure about this one, the BSN is comparable to the American Social Security Number, but it's not the document number of Dutch identity cards. We might need to...
I have merged master in my branch.
> Is there maybe a link by PostNL (the national postal carrier) that explains these rules that we can use as a source? I checked their website, and I cannot...
> I found more maps and lists, but couldn't really find a (semi-)official source unfortunately. Others suggest this regex (or similar ones) as well for Dutch postal codes I came...
> Ah nice, and I see they have different countries as well. Could you add those in a separate PR? PostNL provides 20 regular expressions in total. I've compared the...
Is there anything else that needs to be done before this pull request can be merged? Let me know if there's anything I can do to help.
> This change obviously needs test cases. I've added some test cases! Thank you for the suggestion. :+1: > However I am not entirely convinced this change should be merged....
The first argument is the longitude and the second argument is the latitude. You switched them.
Maybe this happens happens because of limited precision in the polygon file? That seems to me like a logical explanation.