Robin Sergeant

Just noticed that I accidentally reverted some formatting improvements made in the previous commit. I will push another commit to fix this. It must have happened during the merge.

[grafix.zip](https://github.com/mamedev/mame/files/14170573/grafix.zip) My test binary in case anybody wants to try it. Zipping made the file 10 times bigger, but a recognised file extension was required! To run load from mame...

> Just noticed that I accidentally reverted some formatting improvements made in the previous commit. I will push another commit to fix this. It must have happened during the merge....

Please see https://github.com/mamedev/mame/pull/12031 for further work on this driver. You might want to close this PR without delivering after review and only deliver the new PR. Not sure what is...

Closed as super-seeded by later PR.

Just fixed a logic error with my underline attribute check. I was only swapping the last row (instead of the last two rows) when underlining. Visually it made no difference...

> This does look like a big simplification that will be nice to get in. Great, thanks for reviewing @cuavas. I've addressed your comments so should be good to go...

> Usually, the way to submit data/roms is by following this guide: https://wiki.mamedev.org/index.php/Submitting_Source_Code#Submitting_ROM_or_disk_dumps Thanks @simzy39, I've followed that guide and emailed the rom.

> I’m concerned that this may lead to confusion later, because developers expect a machine configuration function name to represent a distinct machine configuration. > > Using a virtual `configure`...

> You could have a fds(machine_config &config) method which adds what's in if (bFDS) and have void rm380z34d(machine_config &config) { rm380z34e(config); fds(config); } Thanks @galibert. That is another way of...