Robbie-Microsoft

Results 52 comments of Robbie-Microsoft

@dyuan-boxlabs We're taking a look at this, but in the meantime, can you change your DefaultAzureCredential config to look like the following? ``` const keyVaultCredentials = new DefaultAzureCredential({ authorityHost: "https://login.microsoftonline.com/REPLACE_WITH_YOUR_TENENT_ID",...

@dyuan-boxlabs Please send it to @bgavrilMS, he will forward it to me.

@ericcan @aleclair-KoAi @joaquingomez-tc @wenytang-ms I can only reproduce this issue when thumbprint and privateKey are both empty strings. Can you all doublecheck your thumbprint and privateKey values and let me...

Sure, a specific line would help. I think the regression was introduced in this PR: [Client Assertion implementation now accepts an async callback as well as a string argument](https://github.com/AzureAD/microsoft-authentication-library-for-js/pull/7014)

> @Robbie-Microsoft > > See [this comment](https://github.com/AzureAD/microsoft-authentication-library-for-js/commit/e6d18c5140359145e0142d4ee4854367fd5da078#r141830832) for a possible place that might be causing the certificate to get lost. Excellent, thanks for this @ericcan . I will be working...

> @Robbie-Microsoft > > > > See [this comment](https://github.com/AzureAD/microsoft-authentication-library-for-js/commit/e6d18c5140359145e0142d4ee4854367fd5da078#r141830832) for a possible place that might be causing the certificate to get lost. > > > > > > Excellent, thanks...

I was able to reproduce the issue via tinkering with our unit tests and developed a fix via the linked PR. Unit tests are needed before review + merging into...

Fixed in v2.8.1, which is now available to install.

It appears this consistency appears in a few other node samples. @teofilomonteiro are you interested in making this change to the other relevant node samples?

> It appears this consistency appears in a few other node samples. @teofilomonteiro are you interested in making this change to the other relevant node samples? @teofilomonteiro If you're planning...