Rob Tillaart
Rob Tillaart
In practice that means I have to disable the compile tests for examples using SWS for those boards. It might be worth adding a few lines on this in the...
@ianfixes used the following ```.arduino-ci.yml``` to compile the example for the platforms that support SoftwareSerial See https://github.com/RobTillaart/MHZCO2/tree/master/examples/MHZCO2_sw_serial ```yml platforms: rpipico: board: rp2040:rp2040:rpipico package: rp2040:rp2040 gcc: features: defines: - ARDUINO_ARCH_RP2040 warnings:...
**SWS** is build in so the platforms that have it will compile. (we also not include "Arduino Lib" ) Mention **SWS** as external lib fails as it is no external...
Good point, question The Processing Serial.clear(), does that clear the RX buffer or also TX buffer? (no P expert) If we follow the P convention I propose to add the...
(1) makes sense, however nowhere in the current HardwareSerial (AVR) I see a guard like you mention. (2) would this be solved by assigning the tail iso the head? a...
Thanks John, (read the discussion) if we do not use ATOMIC and use _rx_buffer_head = _rx_buffer_tail; **Three cases** - assuming single byte indices - if the rx_complete_irq comes before the...
There are other places in HWSerial where RX_BUFFER_ATOMIC should be used too. I recall from my head flush() as that does also assign to _rx_buffer_tail / head .
All bugs are corner case :)
Open for too long => not relevant anymore for me
@OParczyk et al? Should it be reopened?