Rob Hague

Results 133 comments of Rob Hague

In #1250 it looks like the same as https://github.com/sshnet/SSH.NET/pull/1220#issuecomment-1774128167 I had guessed that that was related to the connections being re-established too quickly. I started looking at SO_REUSEADDR and SO_REUSEPORT,...

`AppendAllText` is not aware about file types. It is just appending the bytes of the input to the bytes of the file. I imagine you would get the same result...

This sounds like #957, although I wouldn't know why there is a difference between Windows and Linux.

@zengnanhua By "front-end terminal", are you referring to the console instance of your app? Or otherwise could you clarify? @scott-xu Please consider providing a more informative explanation when closing issues.

> What rationele did you apply for deciding when to "protect" logging with a corresponding `IsEnabled(...)` check? If the message is a literal string, I did not guard it. >...

I am not certain, but I think your connection is performing certificate-based authentication, which unfortunately is not currently implemented https://github.com/sshnet/SSH.NET/blob/5803ada7cf8e373016d673c7c1922c8154b6e22a/src/Renci.SshNet/Security/CertificateHostAlgorithm.cs Does that sound right?

You are correct. The PR is just small clean-up in the case that `Dispose` is not called.

> > @drieseng What do you think about this PR. > > I'm ok with removing the finalizer when there's no added value, but it made sense to keep the...

Closing per https://github.com/sshnet/SSH.NET/issues/562#issuecomment-2168778374 (sorry)