Enable diagnostics in release

[Rob-Hague]

This should make troubleshooting apps easier

[Rob-Hague]

What rationele did you apply for deciding when to "protect" logging with a corresponding IsEnabled(...) check?

If the message is a literal string, I did not guard it.

Can you perform (and commit) a (a simple connect) benchmark that shows the impact on performance with all tracing disabled (with any without this PR applied)?

I don't think we have benchmarks where we make use of our docker infrastructure.

I don't think a benchmark would be suited for such an end-to-end networking scenario (too much noise). The module shows as ~1% of CPU of a basic connect->listdirectory->downloadfiles scenario at verbose level, and does not show in a memory trace.

Where we could use the benchmarks project is to define a number of scenarios from which it is easy to generate profiles for identifying where we should place the focus on performance. I found a nice blog which could be used as a reference 😉