Olaoluwa Osuntokun
Olaoluwa Osuntokun
Pushed up a commit to add a config option that gates if BIP 324 is used or not. It defaults to false for now.
Have been running this without issue for the past week. Confirmed the downgrade logic works for both inbound and outbound peers. Interop with the only other implementation that supports this...
> The following parts exist (see commit message prefixes marking the start of a part): This prefix seems to have been dropped in the latest rebase?
I pulled in the msg router specific comments from this PR into the original PR adding it: https://github.com/lightningnetwork/lnd/pull/8520 Ideally we can get this one in quickly, then rebase this over...
@ProofOfKeags > Ok so the biggest thing I want to challenge is the idea that we should use an Option for the tapscript root. IIRC we always have a tapscript...
> do we need to create new witness sizes in input/size.go? No, nothing changes re the witness size.
> Cool think all my comments are addressed - just need to fix the merge conflict to let the CI run. Ok, fixed the last merge conflict and also an...
Yeah seems like something we should clarify in the spec. My reading isn't the party making the invoice shouldn't set both bits, but the reader should treat it as mandatory...
Doesn't the truncate logic take care of this? https://github.com/lightninglabs/neutrino/blob/27977e1af13774a556fd2e62ebef1f32667a0fdb/headerfs/store.go#L241-L248
On second thought, there's a TODO above there that mentions we don't expect the index to be ahead of the file. It's possible to have a distinct loop that'll replace...