RichardAH
RichardAH
Thanks for the review, Nik. I will get on to these suggestions when back at work
> @RichardAH - I think the issue might be that you used curly braces for the std::string constructor. Can you try using parentheses? `std::string raddr((char*)(memory + read_ptr), read_len);` greg ```c++...
> The first one is because the enum `OVERFLOW` in `app/hook/Enum.h`: > > ``` > OVERFLOW = -30, // if an operation with a float results in an overflow >...
> > I've actually seen this conflict before (can't recall when). It doesn't occur on the compilers I use but I will change the name for you now. > >...
> The current version of rippled from XRPL (1.9.2) builds fine with stdc++17 and boost 1.71. Not sure where these new requirements originate from. I'm trying to build the Hooks...
> I cannot build this on centos 7 with devtoolset-10 or 11 and gcc11 is what we deciced we'd be building with. We also use a similar setup for our...
These are some of the common usecases for Hooks indeed.
A hack to prevent amount clobbering is to produce a new errorcode: `tecPRECISION_LOSS` whenever two amounts that are severely incompatible interact. Something like the following math could be used, where...
https://devpost.com/software/payid-dns
> We're definitely excited about this. We plan to address this proposal at the next PayID working group on Wednesday, 7/22. We invite you to participate and help the discussion....