Rich Harris

Results 788 comments of Rich Harris

Is a deep merge necessary? Would it be sufficient to do this? ```js export function reset (data) { const state = {}; Object.keys(this.get()).forEach(key => { state[key] = undefined; }); if...

I made this comment on https://github.com/sveltejs/hn.svelte.dev/pull/3 but it's probably more applicable here: > Thank you. I'm not certain this is what we want — aren't query string parameters often used...

thank you! @geoffrich can I ask you to take a look at this — is `presentation` the right role, or would `button` (or something else) be more correct in this...

Oh and there's also #567 which additionally adds an `aria-label` — is that appropriate in this context?

Specifically, if you visit https://learn-svelte-dev-git-streaming-svelte.vercel.app/tutorial/streaming and hit 'solve', the page buffers, making navigation very slow

> the page buffers, making navigation very slow note that you need to hit the refresh button to see this (it streams correctly on soft navigation, but it buffers on...

Where is the typo?

This library just wraps Svelte components in some boilerplate to register a custom element — it *doesn't* polyfill the environment if custom elements aren't supported. You could try adding https://github.com/webcomponents/custom-elements...

In your entry module, I would add an import statement at the very top, something like this: ```js import 'custom-elements/dist/CustomElements.min.js'; import 'custom-elements/dist/MutationObserver.min.js'; import { register } from 'svelte-custom-elements'; import Counter...