Rexios

Results 69 comments of Rexios

I based what I was doing off of the existing circle, marker, polygon, etc code. Are there native tests for those?

Oh yeah there are in java, but they seem to only test that values that are passed into the constructor are transformed properly which looks irrelevant to the heatmap code....

I do know that if the method handlers don't have a case for `heatmaps#update` the integration tests fail. Every `update` method gets called when the map is created.

CI failure from before I implemented the method on iOS: https://github.com/flutter/plugins/runs/6032704090

I have a branch with this merged in with other changes: ```yaml dependencies: google_maps_flutter: git: url: https://github.com/Rexios80/plugins-1 ref: 27485e299eb3aa0025b707e3a8a9d37da301c914 path: packages/google_maps_flutter/google_maps_flutter google_maps_flutter_web: git: url: https://github.com/Rexios80/plugins-1 ref: 27485e299eb3aa0025b707e3a8a9d37da301c914 path: packages/google_maps_flutter/google_maps_flutter_web dependency_overrides:...

Is it just me or does the master branch have unresolved analysis issues?

I freshly cloned the actual repo (not my fork) to make sure I'm not crazy:

I noticed because I had to fix those same issues in my completely unrelated PR: https://github.com/flutter/plugins/pull/4916

Are you saying this should only be an issue on flutter channel master? Because I'm on flutter channel stable.

Alright this PR has had master merged into it so many times I think it's going to need another thorough review to make sure the changes are actually what they're...