Reuben Bond

Results 186 comments of Reuben Bond

@benjaminpetit ptal @pentp please take a look, too, if you get the chance :)

TODO: * [x] hash grain methods to generate method id * [x] Add analyzer to annotate methods with their id to enable refactoring * [x] Tests for string-based method aliases

Hi @vrecluse, this looks like an issue with the Prometheus package which you're using, which I assume is from here: https://github.com/zh6335901/Orleans.TelemetryConsumers.Prometheus

We cannot synchronously determine whether a message is going to be sent to the same silo or another silo: that can require a lookup which is further down the pipeline...

> Okay, but the defensive copy isn't needed until the target grain method is invoked, unless the goal is to protect against the message object being mutated before the Task...

The serializer in Orleans 4.x is fairly well optimized. If you're interested, watch this presentation I gave about some of the considerations taken when designing/building it and the accompanying RPC...

> I assume that the defensive copy is taken synchronously with the call site, otherwise the caller could mutate the message object before/while it is copied. Is that correct? Correct....

> Would you like me to open a new issue for this feature request? I don't think we need to - it will naturally be considered during perf optimization cycles...