rosnodejs icon indicating copy to clipboard operation
rosnodejs copied to clipboard

Published 20 hours ago • verified publisher icon RethinkRobotics-opensource

remove master/slave references

Open trusktr opened this issue 5 years ago • 4 comments

It will be more respectful for all possible users to remove the master / slave terminology from the lib.

https://github.com/RethinkRobotics-opensource/rosnodejs/blob/af5d458829fe8103ea45fcd51498140d2b7cba85/src/lib/RosNode.js#L22-L23

PR with initial replacements: https://github.com/RethinkRobotics-opensource/rosnodejs/pull/152. I'm not sure what will break yet.

:black_large_square:

trusktr avatar Jun 18 '20 02:06 trusktr

Would it make sense to wait and see how ROS core decides to resolve this issue first? I think it would be very confusing to use different terminology in the ROS libraries than in ROS core.

chfritz avatar Jun 18 '20 14:06 chfritz

I have a feeling it will take more time for ROS core, because it may be a huge breaking change. Do you know if there's interest there?

trusktr avatar Jun 18 '20 17:06 trusktr

No, I haven't spoken with anyone at OSRF lately. I agree though that is could end up being a huge change. It might even require every ROS user to update their code, since the words in question appear in the API itself.

chfritz avatar Jun 18 '20 18:06 chfritz

I think I'd at least like to hear what ROS thinks. Doing this would break the api and make it harder for new and current users.

chris-smith avatar Jun 19 '20 01:06 chris-smith