Thaddeus Crews

Results 265 comments of Thaddeus Crews

Did a few fresh builds & everything's working as expected!

To get the GHA checks to work, you'll need to change the `pre-commit-config.yaml` eslint hook to the following: ```yaml - repo: https://github.com/pre-commit/mirrors-eslint rev: v9.2.0 hooks: - id: eslint name: eslint...

pre-commit already runs on the root directory though, so I don't imagine that's the issue. Given the `.js` files seem to work fine, it's possible the `.html` settings are awry...

eslint run directly seems to be fine; the issue for me came up with pre-commit specifically. But it's possible it was something off on my end, so feel free to...

I have no clue why it'd be failing on GHA when it's now working locally.

I ran into some similar conflict issues when I tried converting to `biome`, and the "solution" was to add this to the top of `platform/web/eslint.config.mjs`: ```js import eslint from 'eslint';...

This "works", but it's not ideal; now anytime a js/html file is added/modified, the pre-commit hook has to perform a clean install of the node modules.

Not for the *hook* it doesn't; the actual pre-commit action that happens locally: https://pre-commit.com/#quick-start

That's frustratingly specific; excellent work managing to narrow that down!

Tested locally, and got these two warnings/errors: ``` Oops! Something went wrong! :( ESLint: 9.2.0 Error: Cannot find module 'espree' Require stack: - C:\Users\Thaddeus\.cache\pre-commit\repos17omlvg\node_env-default\Scripts\node_modules\eslint-plugin-html\src\verifyWithFlatConfigPatch.js - C:\Users\Thaddeus\.cache\pre-commit\repos17omlvg\node_env-default\Scripts\node_modules\eslint-plugin-html\src\index.js - D:\Godot\Github\godot\platform\web\eslint.config.cjs at Module._resolveFilename...