Thaddeus Crews
Thaddeus Crews
I don't think it supercedes that PR entirety; though, it probably would need a different title if left as-is
Did some cleanup work; **now** it supersedes #88074! The only bits I didn't bring over were `print_info` because it felt a little redundant & the "Enable ANSI escape code support...
Ehhh, if we gotta go through that trouble I'll just add that bit of code after all; I'll throw in a note that it should be removed when the minimum...
Hmm, I might've misread the original post; I don't think it's necessarily limited to 3.7 after all. And yet, I've never had any issues with displaying colored text & I...
I double-checked the PR this supersedes, and that error was happening there too. Seems like enabling progress reporting for CI is what caused it, as reverting that fixed the issue.
This wouldn't be the first time a `StringExtensions` method was deprecated in favor of a native alternative; I say we just go for that.
Wait, does making the constructors `constexpr` qualify the structs for unused checks? That's... Interesting
Making these constexpr revealed a strange conflict with unions: clang-tidy wants structs inside unions to have default member initalization, but a union only allows a single field initalizer and that...
I'd sooner assume #89333 as a possible culprit, which added explicit utf8 encoding to unspecified *writes*.
Updated to include `GodotTools.IdeMessaging` as well; while it's still a touchy file, I realized that it was perfectly safe to upgrade to C# 9 without issue, which does include nullability!