RW

Results 178 comments of RW

right, why does someone need the integration as a template engine, what advantages should that bring? the use is quite simple https://github.com/gofiber/template/issues/302#issuecomment-1867929456 comp/components.templ ```templ package comp templ Hello() { Hello...

https://github.com/gofiber/fiber/blob/4e0f180fe3425b92d2c7b7e362182d17c21ee50b/middleware/healthcheck/healthcheck.go#L43 the problem is this check, where the current path should be reduced with the prefix of the current route

@luk3skyw4lker can you help with a fix ?

right, that would be one solution, a second one is to check only the suffix of the route, but that would be a not quite perfect one

https://github.com/gofiber/fiber/blob/main/router.go#L62 https://docs.gofiber.io/api/ctx#route we should reduce it with the information of the current route

someting like this but better ```go switch c.Path()[len(c.Route().Path):] { case cfg.ReadinessEndpoint: return isReadyHandler(c) case cfg.LivenessEndpoint: return isLiveHandler(c) } ```

```go func Test_HealthCheck_Group_Default(t *testing.T) { t.Parallel() app := fiber.New() app.Group("/v1", New()) v2 := app.Group("/v2/") customer := v2.Group("/customer/") customer.Use(New()) req, err := app.Test(httptest.NewRequest(fiber.MethodGet, "/v1/readyz", nil)) utils.AssertEqual(t, nil, err) utils.AssertEqual(t, fiber.StatusOK, req.StatusCode)...

thanks for the report, probably the error is in the functionality we use from fasthttp can you try the whole thing directly with the fasthttp fs handler and see if...

@HHC26 can you give concrete examples for every point (1-4) and show how the fiber api should look with these features please also put it in relation to the expressjs...