Chengpeng Yan

Results 42 comments of Chengpeng Yan

Though affect the version5.0-5.2. But we don't need to cherry-pick to version5.0-5.2. Just add the label to record.

THE pr https://github.com/pingcap/tidb/pull/38802 handle the same problem but in a more reasonable way. So we don't need this PR because that PR has changed the code of this PR.

Hi, I'm very interested in this task. Could I work on it? Thank you very much! @wuputah @Tishj

@wuputah Thanks for your suggestion. I'll try to implement some types which are compatible now. I have some questions want to ask. 1. Are there any discuss about how to...

@wuputah @hlinnaka What do you think the best way to fix this issue? 1. support `standards_conforming_strings` in `duckdb` for compatible. -> I see tThe purpose of this guc is to...

Hi, I'd like to take this task.

> Some quick cursory review. I'll look at the actual code later. > > Tests are failing on PG17. Seemingly because of a changed error message string. If you cannot...

@JelteF Thanks for your review! All the comments(except the test failed in PG17) are address. PTAL

> Regarding the test failure in PG17, which happens due to a different error message in that PG version. The approach we take so far for cases like this is...

@Y-- Updated. Thanks for your review. PTAL.