tidb
tidb copied to clipboard
pingcap
planner: don't push down some conditions to projections
What problem does this PR solve?
Issue Number: close https://github.com/pingcap/tidb/issues/35623 close https://github.com/pingcap/tidb/issues/37971
Problem Summary: Some conditions shouldn't be pushed down to projection.
What is changed and how it works?
Check whether the conditions can be pushed down to projection.
Check List
Tests
- [ ] Unit test
- [x] Integration test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No code
Side effects
- [ ] Performance regression: Consumes more CPU
- [ ] Performance regression: Consumes more Memory
- [ ] Breaking backward compatibility
Documentation
- [ ] Affects user behaviors
- [ ] Contains syntax changes
- [ ] Contains variable changes
- [ ] Contains experimental features
- [ ] Changes MySQL compatibility
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
None
[REVIEW NOTIFICATION]
This pull request has been approved by:
- AilinKid
- xuyifangreeneyes
To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.
The full list of commands accepted by this bot can be found here.
Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
This pull request has been accepted and is ready to merge.
TiDB MergeCI notify
🔴 Bad News! New failing [4] after this pr merged. These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!
| CI Name | Result | Duration | Compare with Parent commit |
|---|---|---|---|
| idc-jenkins-ci-tidb/integration-common-test | 🟥 failed 4, success 13, total 17 | 19 min | New failing |
| idc-jenkins-ci-tidb/common-test | 🟥 failed 3, success 8, total 11 | 8 min 11 sec | New failing |
| idc-jenkins-ci-tidb/sqllogic-test-2 | 🟥 failed 2, success 26, total 28 | 7 min 11 sec | New failing |
| idc-jenkins-ci-tidb/sqllogic-test-1 | 🟥 failed 1, success 25, total 26 | 5 min 2 sec | New failing |
| idc-jenkins-ci/integration-cdc-test | ✅ all 37 tests passed | 26 min | Fixed |
| idc-jenkins-ci-tidb/integration-ddl-test | 🟢 all 6 tests passed | 30 min | Existing passed |
| idc-jenkins-ci-tidb/tics-test | 🟢 all 1 tests passed | 9 min 23 sec | Existing passed |
| idc-jenkins-ci-tidb/integration-compatibility-test | 🟢 all 1 tests passed | 3 min 5 sec | Existing passed |
| idc-jenkins-ci-tidb/mybatis-test | 🟢 all 1 tests passed | 3 min 5 sec | Existing passed |
| idc-jenkins-ci-tidb/plugin-test | 🟢 build success, plugin test success | 4min | Existing passed |
THE pr https://github.com/pingcap/tidb/pull/38802 handle the same problem but in a more reasonable way. So we don't need this PR because that PR has changed the code of this PR.