Remi Lehe
Remi Lehe
Thanks for this pull request! However, at this point I am not sure that I fully understand the purpose of the changes. Could you edit the description above in order...
I agree that it would be great to have the possibility to easily to lineouts. If possible it would be great if the lineout API is compatible with the `slicing`...
Hi Soeren, I think that the problem is due to the fact that the mathematical operation that is implemented in `get_spectrogram` is not a Wigner transform: - The Wigner transform...
Actually I think the formula in https://en.wikipedia.org/wiki/Wigner_distribution_function was written for the case where `x` is intrinsically a complex number (e.g. a wavefunction in quantum mechanics). But I think that it...
Great! That sounds good! Depending on what you prefer, you could: - Implement a separate method `get_wigner_transform` - or simply add an optional `method` argument to `get_spectrogram`, for instance `method='frog'`...
Thanks for these suggestions! I agree that the user should be able to override the `interpolation` argument. Just to understand better: regarding the `ax` and `figsize` arguments: it seems that...
OK, agree that this could be an interesting feature. Would you be okay with making a full PR from this? Then we can see also with @ax3l and @soerenjalas if...
Also, I think that this is an opportunity to change the import statement from ``` import opmd_viewer ``` to ``` import openpmd_viewer ``` We could leave a stub in the...
Ok, I created a new branch (`upcoming-1.0`) for this purpose. PR #195 has been routed to this branch now.
Thanks a lot for this PR @dpgrote! I'll add a small example in the notebook tutorials, and then I'll merge.