Remco Krams comments

Repositories
Issues
Comments

Results 3 comments of


                                            Remco Krams

🐛 No good error message when adding a client directive to an Astro component

I think this Regex is the issue: https://github.com/withastro/astro/blob/4819e7b071b20911dbb16b0701138655ef97cd62/packages/astro/src/runtime/server/index.ts#L653 Negative-lookbehind regexes are not supported in Safari. @matthewp What is the reason for the lookbehind? I don't notice any difference when I...

🐛 BUG: astro-embed integration fails due to .astro file extension error

It seems like the `noExternal` option does not contain the `@astro-community/astro-embed-integration` dependency because it's referenced from `astro-embed`. The logic for `getAstroPackages` only looks 1 level deep. I was able to...

fix(react): generate correctly when --js is used for module federation host/remote

Hello, it would be great if someone can review my pr and give me some feedback.