Rémi Delaporte-Mathurin

Should it be a new reactor or an adaptation of the existing ones ?

Yep you are right :-) It's just that in the future it might get complex with BallReactorWithPorts, SingleNullBallReactorWithPorts, SingleNullBallReactorWithPortsWithDTFCoils, etc.. haha But it's okay for now I guess

That could be an idea. But then again i'm not convinced it is worth it ? it would mean a whole new test suite for just for checking that an...

Importing them at all times and only importing the packages when the functions are called is really fine. Just not sure of the added value of the try/except thing. I...

Is this a doublon of #84 ?

I think an example of how to produce meshes from CAD with GMSH and then convert it using meshio would be great. Advanced meshes need to be done with dedicated...

@Shimwell when you say "CAD geometry is always going to be written in mm in the stp file" : i thought the stp files were dimensionless ? As said earlier,...

This shows an example of a scaling method in paramak.Shape() which scales the points attributes coordinates. https://github.com/RemDelaporteMathurin/paramak/blob/84d7926259ed365e791ea792cd0c6dc807923e34/paramak/shape.py#L400-L411 https://github.com/RemDelaporteMathurin/paramak/blob/84d7926259ed365e791ea792cd0c6dc807923e34/paramak/utils.py#L7-L16

If they inherit from Shape() and Shape() has a units arg then they'll inherit the units arg I'm afraid.

So: - reactors are stated in m - Parametric components have a units arguments (default in m) points attribute can be scaled from the current unit to another unit. What...