paramak icon indicating copy to clipboard operation
paramak copied to clipboard

testing importError with new CI

Open shimwell opened this issue 4 years ago • 3 comments

Testing of import errors would ideally be implemented into the test suite.

We don't currently test the following lines

    except (ImportError, ModuleNotFoundError):
        msg = "Conversion to VTK requested," \
            "but the Python VTK module is not installed."
        raise ImportError(msg)

In this particular case this vtk package is needed for the neutronics but not needed for geometry construction.

So we could have another CI that performs geometry only tests and check these.

The new CI could be based on a Docker image that does not include any neutronics dependancies

shimwell avatar Jan 14 '21 15:01 shimwell