Alex Reichenbach

Results 13 comments of Alex Reichenbach

I think I see the problem. It's coming from ``` if (dilation_rate !== 1 && strides !== 1) { // Currently, specifying any dilation_rate value != 1 is incompatible with...

Yeah. I reread your condition. I think the condition is correct. Which means that at some point before then, those numbers must have been changed. In the model.json file, all...

I got it building. I put in ``` if (dilation_rate !== 1 && strides !== 1) { // Currently, specifying any dilation_rate value != 1 is incompatible with specifying any...

Ah, so they're tuples. Just saw your response. I'll write a patch for now.

Added ``` if (Array.isArray(strides)) { this.strides = strides[0] } if (Array.isArray(dilation_rate)) { this.dilation_rate = dilation_rate[0] } if (Array.isArray(kernel_size)) { this.kernel_size = kernel_size[0] } ``` and ``` var dilation_rate_temp = this.dilation_rate;...

I think I may have fixed it on my local machine and not submitted a PR. I'll do that today.

The model seems to output correctly, with the output of model.modelDAG being ``` activation_1: inbound: ["batch_normalization_1"] layerClass: "Activation" name: "activation_1" outbound: ["max_pooling1d_1"] __proto__: Object activation_2: {layerClass: "Activation", name: "activation_2", inbound:...

Isolated the problem layer using brute force. It's the MaxPooling1D layer. Probably #79, repeated.

Found the bug! It was same as #79. I rewrote the _Pooling1D.js It no longer outputs NaN. Here are the changes... ``` /** * _Pooling1D layer class */ export default...

Sorry to be a bother, but the description says that it has partial support, it's just 'disabled for now'. How may one go about re-enabling it, so as to attempt...