RedDwarfian

Results 3 comments of RedDwarfian

The instances of `default: assert(false);` in the part of the Deserializer that handles the `mapKeyValueEntryTable` would never get called under normal circumstances. This would require malformed, or manually edited buffers...

I'm also not sure why this is necessary. JSON serializers/deserializers don't require annotations for objects to be serialized/deserialized; except for special cases such as values that should be `JsonIgnore`d. Those...

It is not clear in the Naive `Buffer.from` code where non-string arrays such as `Array` are handled. I would suggest adding a comment to clarify that.