Paul Jacks comments

Results 5 comments of


                                            Paul Jacks

`<UnderlineNav>` menu now uses the Anchored Position on smaller screen sizes to not clip, or go out of bounds.

Sorry :pray: . I seem to have done a wonky-merge. Recreated the PR, feedback and conversation can be found [here.](https://github.com/primer/react/pull/4221)

`<UnderlineNav>` menu now uses the Anchored Position on smaller screen sizes to not clip, or go out of bounds.

Copy+Pasting my last message: Woop woop! 🎉 Thank you a billion for the feedback, @broccolinisoup. It really helps with the implementation and understanding what the aim is 🙏. Here's how...

`<UnderlineNav>` menu now uses the Anchored Position on smaller screen sizes to not clip, or go out of bounds.

To summarize the current fix, based on @broccolinisoup's feedback: 1. I moved the clientWidth calculation outside of the menuStyles to not force the getAnchoredPosition to run on each render, instead...

:+1: DX | Making sure `storybook` can be started encapsulated from the `docs`.

Sorry @rezrah, I just updated the branch, mind triggering the workflows again, so I can see whats wrong and fix it?

:+1: DX | Making sure `storybook` can be started encapsulated from the `docs`.

I'd love to fix those failing actions, but I do not think I am allowed to. It looks like they are asking for secrets. Ui test, Visual test, & Deploy...