Rebecca Stevens

Results 253 comments of Rebecca Stevens

@dsl101 If you want `customMerge` to be called on everything, have `isMergeableObject` be a function that always returns `true`. You'll just need to make sure that your custom merge function...

You could do this: ```js const opts = { isMergeableObject: () => true customMerge: key => { if (key === 'shares') return sumShares return (x, y) => { if (myIsMergeableObject(x)...

The keys in an object should always be treated as if they don't have an order. > ### 4.3.3 Object > An object is a member of the type Object....

All the tests should now be running. Unfortunately they're not all passing any more :cry: This PR has been quite a bit more work that I initial thought it would...

All the node tests are now passing :grin: I'm not sure why one of the web tests isn't :confused:

I believe everything should be working now. With regard to `test_minify_sync` and `test_minify_async`; the distinction was because synchronous tests would fail when running a test that can only compete asynchronously....

> There shouldn't be any tests that only work in asynchronous mode That is true for the existing tests but I have added a few extra tests that only apply...

So with regard to the `Maximum call stack size exceeded` error that occurs with `Amazon.html`; the error occurs because there are too many callbacks being put onto the stack. When...

The `Maximum call stack size exceeded` error should no longer occur. If a callback is provided to `minify` all internal `Task` callbacks will now be made async. This unfortunately has...