Rebecca Stevens

Results 253 comments of Rebecca Stevens

What sort of change would you like to see for this? A new option? How do you think it should work? Note: we already have `ignoreLambdaExpression`, a sub-option of `enforceParameterCount`.

@arthur-leclerc There's already an option for that: https://github.com/antfu/vscode-iconify/blob/d295384d5f642791f52d36432b58369e4fac1603/package.json#L526-L530

@lumosminima You'll want to use `customAliasesJsonPaths` instead of `customCollectionJsonPaths`. `customCollectionJsonPaths` is for providing your own custom icon set.

Iterator helpers seem to be coming to JS (currently Stage 3) (https://github.com/tc39/proposal-iterator-helpers). There's a polyfill available on npm: https://www.npmjs.com/package/iterator-helpers-polyfill Otherwise, I'd recommend this library: https://github.com/vitaly-t/iter-ops

Only use `"exports"` and `"main"`. Don't use `"module"` - [Node.js ignores the top-level "module" field](https://nodejs.org/api/esm.html#esm_dual_commonjs_es_module_packages:~:text=Node.js%20ignored%20(and%20still%20ignores)%20the%20top%2Dlevel%20%22module%22%20field), without the `"module"` field webpack won't have any issues. ```json "exports": { "require": "./index.cjs", "default":...

Hmm, I thought rollup and the likes would be supporting "exports" but after looking it it seems they're not. Here's the original issue on the matter: https://github.com/rollup/plugins/issues/208 Well it would...

Looking at the original use case of this issue, this is how I would handle such a case: ```js const mergedConfig = env === 'dev' ? merge(config, config_dev) : config;...

#217 fixes this but I don't know how it does. I ran this test case there and it works correctly (it not fixed #215)

~~@TehShrike maybe `customMerge` should supply more arguments and be of a similar signature to [_.mergeWith's customizer function](https://lodash.com/docs/#mergeWith).~~ - This probably isn't needed I also think it would be a good...