Philipp Dallig

Results 161 comments of Philipp Dallig
trafficstars

I would prefer the Spark log format without `:%L`. Otherwise we have the confusing log line number. Take a look at the Spark project. https://github.com/apache/spark/blob/v3.2.0/conf/log4j.properties.template#L23 The second screenshot also contains...

> BTW, did you have any experience with PF4J before? I heard it for the first time so I just wonder if you are already familiar with it or not....

@zjffdu For a first feedback I would be very grateful.

@jongyoul I've been thinking about this approach for a while, and I think I wanted to use the pf4j library to compensate for the lack of hk2 in zeppelin-zengine. What...

I think we should wait with this PR until after the release of 0.9.0.

Why don't you work with a subpath (concat a subpath to nodebookdir)? I think it should make things easier.

I think I understand your approach. You should change your view. `ZEPPELIN_NOTEBOOK_DIR` should handle the Git Root-Directory you should introduce a new variable like `ZEPPELIN_NOTEBOOK_GIT_SUB_VIEW`. Use this variable (if set)...