zeppelin
zeppelin copied to clipboard
[ZEPPELIN-5648] log4j.properties is not configured properly for spark interpreter
What is this PR for?
For spark interpreter, the class name and method are not printed (It is always Logging.scala). This PR fixed this issue by updating the log4j.properties.
What type of PR is it?
[Bug Fix ]
Todos
- [ ] - Task
What is the Jira issue?
- https://issues.apache.org/jira/browse/ZEPPELIN-5648
How should this be tested?
- Manually tested
Screenshots (if appropriate)
Before this PR

After this PR

Questions:
- Does the licenses files need update? No
- Is there breaking changes for older versions? No
- Does this needs documentation? No
Please provide an example (after, before).
It seems that the Zeppelin server log4j configuration is also adjusted. There should not be the Logging.scala problem.
Thanks for the review @Reamer I added the screenshot
Thanks for the screenshots.
I think that the line number :57 is very confusing. We should remove the line number of Logging.scala as well.
In addition, it seems that you also adjust the log4j configuration of the Zeppelin server. The Zeppelin server is not affected by this issue. Here, of course, the previous output is much more helpful.
Sorry for late response @Reamer :57 is very confusing This is in the first screenshot (before this PR), the second screenshot is the logs after this PR.
The reason I update log4j.properties of zeppelin-server is just to make the logs of zeppelin-server & interpreter consistent.
I would prefer the Spark log format without :%L. Otherwise we have the confusing log line number.
Take a look at the Spark project.
https://github.com/apache/spark/blob/v3.2.0/conf/log4j.properties.template#L23
The second screenshot also contains the confusing log line.
:57 is the logging line in Logging.scala