Philipp Dallig

Results 208 comments of Philipp Dallig

> Why is `ZeppelinConfiguration` in the `zeppelin-interpreter` module? In my opinion, we should split this up. ZeppelinConfiguration belongs to the Zeppelin server, and the Zeppelin interpreter should really only work...

The test is being tested by CI. I don't see any problems in the current master version.

I am currently against the introduction of an event bus. As Jongyoul Lee wrote in an email, we should use the existing resources to ensure communication. https://lists.apache.org/thread/nk85rcn4qomxgpw56xjd804h3j9w7vz7 It has been...

This pull request is a workaround for me, because the ServiceLocator should actually be executed when Zeppelin is shut down. https://github.com/apache/zeppelin/blob/d7740440d1992606c577e1e0d5f884d3d4bb3286/zeppelin-server/src/main/java/org/apache/zeppelin/server/ZeppelinServer.java#L357-L377 Somewhere here should be `sharedServiceLocator.shutdown();`. Unfortunately, my efforts failed...

What do you think about making the private methods static as well? With the current implementation, it is not clear to me in which order the private methods must be...

You have definitely come to the right place. I am open to pull requests to fix this problem.