Philipp Dallig

Results 161 comments of Philipp Dallig
trafficstars

You should move this logic into the JDBC interpreter.

A few thoughts about your work: - All functionality is located in the JDBC interpreter. All new dependencies and classes should also be located there. - It seems that in...

ping @akishichinibu Any JUnit tests to add?

Hello @grizzly-monkey, thanks for your Pull Request. We already have a sanitize method. Have a look at `K8sUtils:generateK8sName`. Please use this method or adapt the method to your needs.

> when does it get merged ? When all tests have been successfully completed.

I created https://github.com/grizzly-monkey/zeppelin/pull/1 to fix this feature.

Hi @Super-Sky Thank you very much for your contribution. Please take out the file formatting from your commit.

@pima29 Please close the issue when it is resolved. @jprusch Thank you for your help.

No that is not right. The channel is just the name of the channel. For example `monitoring`