R. de Wilde

Results 45 comments of R. de Wilde

You should add the dependency, you should lock it to a specific tag/release. When you update your code, you could update the dependent version too. https://github.com/hybridauth/hybridauth Packagist should index all...

Maybe consider creating a seperate branch, as you should not directly include the hybridauth source into your own source. It would be managed through composer dependency.

I understand it'll be a breaking change, but you could consider integrating into composer autoloading as Yii is also committing to the PSR\* conventions which are also used by composer...

I understand. Will fork. You can actually fork the hybridauth repository to your own user. Add your changes to it (overwrite). Commit and push to your own fork. Include the...

Yes, I manually copy the files from `main` to `commonMain` now. Sounds like it will be a little too hard for me to fix. Maybe I'll give it a try....

This line should implement an object factory? https://github.com/JetBrains/kotlin/blob/988df517dd5c0159315b3d1da94712bdd635e681/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/plugin/sources/KotlinSourceSetFactory.kt#L26 And this inteface should implement `ExtensionAware`? https://github.com/JetBrains/kotlin/blob/deb416484c5128a6f4bc76c39a3d9878b38cec8c/libraries/tools/kotlin-gradle-plugin-api/src/main/kotlin/org/jetbrains/kotlin/gradle/plugin/KotlinSourceSet.kt#L12 > and take the kotlin multiple plugin into consideration during bootstrapping. Not sure what this...

@marcoferrer Is this safe to test yet?

Development of pb-and-k has been slowed down due to the original developer having limited time. Therefore I think MP support for this project is something many would like.

> (..) It looks like the bug is addressed in versions `0.10.0-eap-1` and `1.3.20-eap-52` with an expected release in `1.3.20` We're past `1.3.20` \o/

Was there already work done on the kotlinx integration? @marcoferrer